Fix parsing image assets from a Markdown line along with other markup #7742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every regex that tries to match a substring with .* or .+ is
guaranteed to be wrong. In this case, it was giving incorrect matches
straddling multiple quoted attributes:
<img __ASTRO_IMAGE_="../assets/image.png"> and <a href="link">link</a>
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Fixes withastro#7741.
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
🦋 Changeset detectedLatest commit: 2bb2341 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
approved these changes
Jul 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Every regex that tries to match a substring with .* or .+ is guaranteed to be wrong. In this case, it was giving incorrect matches straddling multiple quoted attributes:
Fixes #7741.
Testing
Tested with the test case in #7741.
Docs
This is a pure bugfix that doesn’t need documentation.