fix: cloudflare waitUntil not working as inteded with getRuntime #7419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
What does this change?
( This might also be an issue for other context runtime functions )
Testing
Tested on our own environment.
Has been tested on our
advanced
mode website.I cannot speak for
directory
mode, but I assume the problem is the same.Docs
No need to update docs,
waitUntil
should now work as intended.Comments
I did not bother to mock waitUntil since we already have a mock In our project.
Its up to the Astro team to decide from this point on. But you could do something like what we do: