-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: document open
option
#7418
Conversation
🦋 Changeset detectedLatest commit: 86fbaa8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also copy the docs to here?
astro/packages/astro/src/@types/astro.ts
Lines 881 to 891 in 8f4a04d
/** | |
* @docs | |
* @name server.headers | |
* @typeraw {OutgoingHttpHeaders} | |
* @default `{}` | |
* @version 1.7.0 | |
* @description | |
* Set custom HTTP response headers to be sent in `astro dev` and `astro preview`. | |
*/ | |
server?: ServerConfig | ((options: { command: 'dev' | 'preview' }) => ServerConfig); |
A bit strange to do so, but maybe good so docs pick up the jsdoc.
Oh, I didn't see that section. Yes, it makes sense to copy them over |
Changes
Closes #7398
For some reason
server.open
wasn't correctly typed. This fixes it.Testing
Manual check
Docs
/cc @withastro/maintainers-docs for feedback!