Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AstroUserConfig's redirect type definition #7366

Merged
merged 2 commits into from
Jun 12, 2023

Conversation

aappaapp
Copy link
Contributor

@aappaapp aappaapp commented Jun 12, 2023

Changes

Testing

No testing is needed for this minor type definition, I think.

Docs

No docs were added as the code now follows the docs.

@aappaapp aappaapp requested a review from a team as a code owner June 12, 2023 07:52
@changeset-bot
Copy link

changeset-bot bot commented Jun 12, 2023

🦋 Changeset detected

Latest commit: ad2151b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 12, 2023
@aappaapp aappaapp marked this pull request as draft June 12, 2023 07:58
@aappaapp aappaapp changed the title Fixed RedirectConfig type definition Fixed AstroUserConfig's redirect type definition Jun 12, 2023
@aappaapp aappaapp marked this pull request as ready for review June 12, 2023 08:10
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straight forward fix. Thanks!

@bluwy bluwy merged commit 42baf62 into withastro:main Jun 12, 2023
@astrobot-houston astrobot-houston mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type '{ "/old-page": string; }' is not assignable to type 'RedirectConfig | undefined'.
2 participants