-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdoc asset bleed, second try #7185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 57e65d2.
🦋 Changeset detectedLatest commit: e109dbb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Related to the core `astro` package (scope)
pkg: integration
Related to any renderer integration (scope)
labels
May 23, 2023
github-actions
bot
removed
the
pkg: astro
Related to the core `astro` package (scope)
label
May 23, 2023
github-actions
bot
added
the
pkg: astro
Related to the core `astro` package (scope)
label
May 25, 2023
I think the windows failure here might be legitimate. I'm going to test on my Windows computer. |
bholmesdev
force-pushed
the
fix/markdoc-asset-bleed
branch
from
May 30, 2023 21:12
f85033b
to
d006c27
Compare
github-actions
bot
added
pkg: example
Related to an example package (scope)
pkg: preact
Related to Preact (scope)
pkg: react
Related to React (scope)
pkg: svelte
Related to Svelte (scope)
pkg: vue
Related to Vue (scope)
labels
May 30, 2023
matthewp
force-pushed
the
fix/markdoc-asset-bleed
branch
from
May 30, 2023 21:24
d006c27
to
f85033b
Compare
github-actions
bot
removed
pkg: vue
Related to Vue (scope)
pkg: react
Related to React (scope)
pkg: svelte
Related to Svelte (scope)
pkg: example
Related to an example package (scope)
pkg: preact
Related to Preact (scope)
labels
May 30, 2023
github-actions
bot
added
pkg: preact
Related to Preact (scope)
pkg: react
Related to React (scope)
pkg: svelte
Related to Svelte (scope)
pkg: vue
Related to Vue (scope)
labels
May 30, 2023
bholmesdev
changed the base branch from
fix/markdoc-stylesheet-render-error
to
main
May 31, 2023 13:52
github-actions
bot
added
pkg: example
Related to an example package (scope)
and removed
pkg: preact
Related to Preact (scope)
pkg: svelte
Related to Svelte (scope)
pkg: vue
Related to Vue (scope)
pkg: react
Related to React (scope)
labels
May 31, 2023
bholmesdev
commented
May 31, 2023
Co-authored-by: Ben Holmes <hey@bholmes.dev>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pkg: astro
Related to the core `astro` package (scope)
pkg: example
Related to an example package (scope)
pkg: integration
Related to any renderer integration (scope)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
manualChunks
to split Astro components as separate modules from themarkdoc.config.mjs
. Vite bundles these in-line by default, which introduced bugs in the previous versionrenderStylesheet
calls to use new APIs (this was broken during the merge in the previous version)Original changes brought back:
markdoc.config.mjs
in version 0.1.0.astroPropagatedAssets
on all Astro component importshandlePropagation
option for content collection integrations. This allows us to toggle asset propagation wrappers on or off by file extension. Ex. MDX needs this wrapper, but Markdown and Markdoc do not.Testing
Docs
N/A, bug fix