-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade shiki to v0.14.1 #6932
Upgrade shiki to v0.14.1 #6932
Conversation
🦋 Changeset detectedLatest commit: 4e3a99f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR is blocked because it contains a |
This is ready for review now. I added additional comments on some changes above that are minimized to keep this page clean. |
Changes
Fixes #6899
pre
tag class, e.g.<pre class="astro-code github-dark">
(feature by shiki itself)NOTE: while this could break theme types in
shikiConfig
, they will still work in runtime so I don't think this is a breaking change.Testing
Existing tests should pass. I also tested the
<Code
component locally so it still works, including the compat stuff.Docs
The only new thing to document is probably the theme name in the
pre
tag, but I'm not sure if it needs to be documented specifically.