feat(image): Export more types and utilities for users to use #6739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d2058b1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
commented
Apr 3, 2023
| @@ -45,7 +38,7 @@ interface GetImageResult { | |||
| * import { getImage } from 'astro:assets'; | |||
| * import originalImage from '../assets/image.png'; | |||
| * | |||
| * const optimizedImage = await getImage({src: originalImage, width: 1280 }) | |||
| * const optimizedImage = await getImage({src: originalImage, width: 1280 }); | |||
There was a problem hiding this comment.
Missing semi-colon here broke syntax highlighting in the hover because of withastro/language-tools#475
Princesseuh
commented
Apr 3, 2023
Comment on lines
+34
to
+37
| width?: number | undefined; | ||
| height?: number | undefined; | ||
| quality?: ImageQuality | undefined; | ||
| format?: ImageOutputFormat | undefined; |
There was a problem hiding this comment.
Adding undefined here makes it compatible with exactOptionalPropertyTypes. Otherwise, building a component is clumsy because you need to filter out every props manually
|
Scanned and didn't see any changes for Astro Docs Maintainers to review, so removed the review request! |
matthewp
approved these changes
Apr 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
While porting my website to
astro:assetsthis weekend and building my own Picture component, I noticed that a bunch of types are annoyingly not exported, this PR fixes thisTesting
Tested manually, types only
Docs
Some of those types were already referred to in the docs, but couldn't be exported. This PR fixes this