Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc link in non-html-pages example README #6369

Merged
merged 1 commit into from
Feb 25, 2023
Merged

Update doc link in non-html-pages example README #6369

merged 1 commit into from
Feb 25, 2023

Conversation

weakish
Copy link
Contributor

@weakish weakish commented Feb 25, 2023

Changes

Replace the following dead link:

/en/core-concepts/astro-pages/#non-html-pages

Also, mentions .js or .ts instead of .md,
since this is a non-html-pages example (.md are for html pages).

Testing

Update README, thus no tests are added.

Docs

This commit itself is a documentation change.

@weakish
Update doc link in non-html-pages example README
b7350c2 
Replace the following dead link:

/en/core-concepts/astro-pages/#non-html-pages
@weakish weakish requested a review from a team as a code owner February 25, 2023 13:04
@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2023

⚠️ No Changeset found

Latest commit: b7350c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Feb 25, 2023
delucis
delucis approved these changes Feb 25, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that @weakish!

@delucis delucis merged commit 9f0ae4e into withastro:main Feb 25, 2023
@weakish weakish deleted the patch-1 branch February 25, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@weakish @delucis