error overlay: show cause if available
#6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d867c5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mayank99
commented
Jan 31, 2023
| this.text('#cause-content', err.cause); | ||
| cause.style.display = 'block'; | ||
| } else { | ||
| this.text('#cause-content', JSON.stringify(err.cause, null, 2)); |
There was a problem hiding this comment.
I originally wanted to check if this is instanceof Error and display it, but for some reason err.cause is missing info and just returns an empty object when i do this:
try {
console.log(something.that.doesnt.exist);
} catch (err) {
throw new Error('oh no!', { cause: err });
}
1 task
Princesseuh
approved these changes
Jan 31, 2023
Merged
matthewp
pushed a commit
that referenced
this pull request
Feb 3, 2023
* show `cause` in error overlay * add extra check for string * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added ability to display an error's
causeif available. Closes #6027Testing
Tested in a local project by changing code inside node modules.
Test fixture currently pending.
Docs
Not needed I think? I guess we could document how to use the
causeproperty.