Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output assets to _astro directory #5772

Merged
merged 16 commits into from
Jan 9, 2023
Merged

Output assets to _astro directory #5772

merged 16 commits into from
Jan 9, 2023

Conversation

natemoo-re
Copy link
Member

@natemoo-re natemoo-re commented Jan 5, 2023 •
edited
Loading

Changes

Testing

E2E tests added to verify the build output and build.assets configuration

Docs

Guidance wanted!

@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c319fc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jan 5, 2023
@natemoo-re natemoo-re marked this pull request as ready for review January 6, 2023 22:39
@natemoo-re natemoo-re requested a review from a team as a code owner January 6, 2023 22:39
delucis
delucis reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some docs suggestions, but looks good! We don’t have any more detailed docs on build output currently but eventually it might make sense to mention this as part of the deployment guides or something. Maybe something like this:

Static assets will be built to /_astro/ by default (configurable using the build.assets option), so that directory can be safely cached immutably if your deployment platform supports it.

packages/astro/src/@types/astro.ts Show resolved Hide resolved
packages/astro/src/@types/astro.ts Outdated Show resolved Hide resolved
packages/astro/src/@types/astro.ts Show resolved Hide resolved
natemoo-re and others added 3 commits January 9, 2023 08:56
@natemoo-re @delucis
Update packages/astro/src/@types/astro.ts
cb111f9 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@natemoo-re @delucis
Update packages/astro/src/@types/astro.ts
952dfeb 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@natemoo-re @delucis
Update packages/astro/src/@types/astro.ts
0ec8013 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@natemoo-re natemoo-re merged commit f8f4d49 into main Jan 9, 2023
@natemoo-re natemoo-re deleted the feat/_astro-dir branch January 9, 2023 16:01
@natemoo-re natemoo-re mentioned this pull request Jan 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move /assets folder to /_astro
3 participants
@natemoo-re @delucis @matthewp