Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix astro preview not working on Windows #5480

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

sapphi-red
Copy link
Contributor

Changes

When running astro preview on Windows, it didn't work with the following error.

Only URLs with a scheme in: file, data are supported by the default ESM loader. On Windows, absolute paths must be valid file:// URLs. Received protocol 'c:'

This PR fixes this error.

Testing

I added a test. Also I tested with adapter-node manually.

Docs

Docs isn't needed as it's a bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2022

🦋 Changeset detected

Latest commit: bedb4f5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 26, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@bluwy bluwy merged commit c137752 into withastro:main Nov 28, 2022
@astrobot-houston astrobot-houston mentioned this pull request Nov 28, 2022
@sapphi-red sapphi-red deleted the fix/preview-in-windows branch November 28, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants