Refactor error handling #5206
Merged
Refactor error handling #5206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6c6a182 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Princesseuh
commented
Oct 26, 2022
| }, | ||
| }); | ||
|
|
||
| // Vite will handle creating the frame for us with proper line numbers, no need to create one |
There was a problem hiding this comment.
This took me by surprise while writing this PR, it turns out that Vite is able to create codeframes by itself whenever an error happens in parts it understands
Sometimes they're better than ours, sometimes not, luckily it checks if we already have one before doing it, so we can case by case it
This reverts commit 5ca34f3.
matthewp
reviewed
Oct 27, 2022
matthewp
reviewed
Oct 27, 2022
matthewp
approved these changes
Oct 27, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a refactor of our error handling intended to bring the actual error handling closer to where the error actually happen instead of downstream.
The ideas being that by the different parts that can cause errors being more isolated, they'll be easier to test individually, it'll be easier to provide as much information as possible to users and eventually, will be easier to recover from (since we can know exactly what happened and where)
An easy example of the benefits is error code support, since we know precisely where the error happened, it's easy to apply a specific error code
This is the first part of a series of PRs and back-and-forth about errors, at the end of it, I'm hoping we'll have awesome and stylish errors!
Fix #5149
Fix #5153
Fix #5154
Testing
Our current error tests all pass!
Docs
N/A