Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hoist hydration script out of slot templates #4891

Merged
merged 4 commits into from
Sep 28, 2022
Merged

Hoist hydration script out of slot templates #4891

merged 4 commits into from
Sep 28, 2022

Conversation

matthewp
Copy link
Contributor

Changes

Testing

  • Test added, ensures that the hydration script is not created within the template.

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 7a61e2c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 27, 2022
@matthewp matthewp marked this pull request as ready for review September 27, 2022 16:24
@matthewp matthewp marked this pull request as draft September 27, 2022 16:40
@matthewp matthewp marked this pull request as ready for review September 27, 2022 17:15
bluwy
bluwy approved these changes Sep 28, 2022
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactors!

@matthewp matthewp merged commit 87a7cf4 into main Sep 28, 2022
@matthewp matthewp deleted the hidden-nested-slots branch September 28, 2022 14:55
@astrobot-houston astrobot-houston mentioned this pull request Sep 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onMount not called in nested hydrated Solid.js components
2 participants
@matthewp @bluwy