Allow passing fetch() Response to set:html #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4cf67b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FredKSchott
reviewed
Sep 21, 2022
| ``` | ||
| * `Iterable`s (non-async): | ||
| ```astro | ||
| <div set:html={(function * () { |
Princesseuh
reviewed
Sep 21, 2022
| @@ -141,12 +142,12 @@ export async function renderJSX(result: SSRResult, vnode: any): Promise<any> { | |||
| ); | |||
| } | |||
| if (typeof output !== 'string' && Symbol.asyncIterator in output) { | |||
| let body = ''; | |||
| //let parts: Uint8Array[] = []; | |||
There was a problem hiding this comment.
Seems like a left over comment?
Princesseuh
approved these changes
Sep 21, 2022
tony-sull
approved these changes
Sep 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
<Fragment set:html={fetch('/posts/legacy-post.html')} />and more.ReadableStream#4828Testing
packages/astro/test/set-html.test.jsfor all scenarios.Docs