.md only: npm init astro --> npm create astro #4760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For consistency with withastro/docs#360. Docs always use `npm create astro` (never `npm init astro`), README.md files in this repo should do the same. Search: `\b(npm|yarn|pnpm) init astro\b` Replace: `$1 create astro` Except for two instances: 1. `packages/create-astro/CHANGELOG.md` -- skipped because changelog. 2. `packages/create-astro/test/create-astro.test.js.skipped` -- skipped, old test disabled in withastro#3168.
|
delucis
approved these changes
Sep 14, 2022
bluwy
reviewed
Sep 16, 2022
Co-authored-by: Bjorn Lu <bjorn@bjornlu.com>
bluwy
approved these changes
Sep 16, 2022
Thank you for catching that! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For consistency with withastro/docs#360. Docs always use
npm create astro(nevernpm init astro), README.md files in this repo should do the same.Search:
\b(npm|yarn|pnpm) init astro\bReplace:
$1 create astroExcept for two instances:
packages/create-astro/CHANGELOG.md-- skipped because changelog.packages/create-astro/test/create-astro.test.js.skipped-- skipped, old test file disabled in Feat: [create astro] add directory prompt #3168.Q: should I run
pnpm exec changesetfor minor changes only touching *.md files? I would guess no.Testing
n/a, no code changes.
Docs
n/a, changes make README.md files consistent with docs, see above.