fix: ensure SSR module is loaded before testing is CSS #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 88bf017 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you! I know this one was probably not easy to debug. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensure SSR module is loaded before testing is CSS in
getStylesForURL.Why
There are some problems when trying to use UnoCSS with Astro in dev. Sometimes the CSS is not inlined in the HTML, making some styles not applied. For example:
I found that's because the
uno.cssSSR module is not loaded when trying to determine whether it is a JS module style. Ensuring loading the SSR module fixes the problem.Testing
Manually tested with https://stackblitz.com/edit/withastro-astro-pzexzk and my blog.
It's not a big change, so no tests were added.
Docs
Just a fix. No docs were added.