Improve MDX glob perf - move Layout to async import #4428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
async
importWait, why an
async
import?We found some interesting
import.meta.glob
behavior in the dev server after #4255 was introduced.Scenario: a directory of MDX files use the same
layout
in their frontmatter. This layout includes anAstro.glob
call for that same directory of MDX files. This is common when generating a "what to read next" section, navigation, etc.I discovered that moving the frontmatter layout from an asynchronous import to a synchronous one introduced this issue. Recursion is to blame here: layout -> glob -> posts, which import -> layout -> glob -> posts, which import -> layout -> glob...
Testing
N/A
Docs
N/A