Mdx/plugin unshift #4248
Merged
Mdx/plugin unshift #4248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fa02b69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
approved these changes
Aug 10, 2022
Merged
aFuzzyBear
reviewed
Aug 11, 2022
| @@ -62,10 +62,10 @@ function getRehypePlugins( | |||
| let rehypePlugins = handleExtends(mdxOptions.rehypePlugins, DEFAULT_REHYPE_PLUGINS); | |||
|
|
|||
| if (config.markdown.syntaxHighlight === 'shiki' || config.markdown.syntaxHighlight === 'prism') { | |||
| rehypePlugins.push([rehypeRaw, { passThrough: nodeTypes }]); | |||
| rehypePlugins.unshift([rehypeRaw, { passThrough: nodeTypes }]); | |||
There was a problem hiding this comment.
I was wondering if there is a slightly better way of doing this, Im never a fan of unshift()
[ [rehypeRaw, { passThrough: nodeTypes}] , ...rehypePlugins ]I feel this returning a new array would be easier, and a more performant solution
There was a problem hiding this comment.
I agree, It's probably a better alternative. Array#unshift was just the first thing that came to mind when I thought about this issue.
aFuzzyBear
reviewed
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pnpm exec changesetPut built in rehype plugins before user added.
Testing
No thorough testing was done due to the complexity of testing every major rehype plugin. Changing the load order should have minimal to no effect on usage.
Docs
No visible change. No documentation mentioned builtin plugins being loaded last.
Why
Specifically the
rehypeCollectHeadingsimpacted one of my rehype plugins.rehypeAutolinkHeadingsrequires ids to be added to headings for it to work, with pre this pr configuration, these ids were added after my plugin being ran.Context in discord thread
@bholmesdev