Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CSS when child component uses Astro.glob on page #4156

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 4, 2022

Changes

  • When a change component does an Astro.glob('../pages/**/*.astro') due to the way we determining what was a page. This fixes that.
  • Fixes 🐛 BUG: Style is not included at all when running yarn run build  #4025
  • Also changes the way we name the CSS assets, instead of using a hash we use the path to the page component. If that name is too long (an arbitrary length) we then do use the hash.

Testing

  • Test added for the bug.

Docs

N/A, bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

🦋 Changeset detected

Latest commit: b459f60

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 4, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but had a small defensive suggestion!

packages/astro/src/core/build/graph.ts Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 82a1063 into main Aug 5, 2022
@matthewp matthewp deleted the glob-missing-css branch August 5, 2022 13:52
@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Style is not included at all when running yarn run build
2 participants