Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test coverage to include more Node and Windows tests #4144

Merged
merged 3 commits into from
Aug 5, 2022

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Aug 4, 2022

Changes

  • Updated CI to test every supported version of Node.js: https://nodejs.org/en/about/releases/
  • Updated CI to take OS and NODE_VERSION into account when using cached tests
  • Updated CI to run every supported version of Node.js on Windows (previously, was only v14)
  • Previously, we'd limited windows to v14 only to improve CI bottlenecking, but other test speed improvements by @natemoo-re may allow us to add this back without impacting CI performance.
  • Adding Node@18 TODO since there are multiple tests that break when node-fetch is replaced with Node@18's global undici fetch.

Testing

  • is testing

Docs

  • N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: 6daec19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Aug 4, 2022
@natemoo-re
Copy link
Member

Somehow it looks like the test artifacts are being shared across environments, which seems wrong. I'll have to take a look at this.

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Aug 5, 2022
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Aug 5, 2022
Comment on lines +18 to +21
"dependsOn": [
"$RUNNER_OS",
"$NODE_VERSION"
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed to exposes these variables to dependsOn so that tests are not hashed only on the file contents. This means test runs will be hashed on the files contents and the current OS and version of Node.

Comment on lines +189 to +190
env:
NODE_VERSION: ${{ matrix.NODE_VERSION }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expose current NODE_VERSION as env variable, used by Turborepo to calculate hash

@natemoo-re natemoo-re changed the title update test coverage to include Node v18, more windows tests update test coverage to include more Node and Windows tests Aug 5, 2022
@natemoo-re natemoo-re merged commit 778a4d2 into main Aug 5, 2022
@natemoo-re natemoo-re deleted the update-test-suite branch August 5, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants