-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update test coverage to include more Node and Windows tests #4144
Conversation
|
Somehow it looks like the |
18ce9e0
to
7a9fb3c
Compare
"dependsOn": [ | ||
"$RUNNER_OS", | ||
"$NODE_VERSION" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We needed to exposes these variables to dependsOn
so that tests are not hashed only on the file contents. This means test runs will be hashed on the files contents and the current OS and version of Node.
env: | ||
NODE_VERSION: ${{ matrix.NODE_VERSION }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose current NODE_VERSION as env variable, used by Turborepo to calculate hash
Changes
Updated CI to test every supported version of Node.js: https://nodejs.org/en/about/releases/OS
andNODE_VERSION
into account when using cached testsnode-fetch
is replaced with Node@18's globalundici
fetch.Testing
Docs