replace custom class:list implementation with clsx

[FredKSchott]

Changes

• Follow up to Handle false properly in class:list #3922
• Replace our custom implementation with the popular clsx implementation
• Our custom implementation was confusing people, like here: https://discord.com/channels/830184174198718474/845451724738265138/993246639345115236
• We actually were documenting our behavior as clsx-like in our docs, and our custom implementation behaved a bit differently: https://docs.astro.build/en/reference/directives-reference/#classlist
• I doubt the not-documented features that our custom implementation supported were in use, given how advanced/odd they were, so I think this should be safe to merge as a patch.

Testing

• Covered by existing tests.

Docs

• Brings code closer to current docs.

[changeset-bot]

🦋 Changeset detected

Latest commit: ee1beb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages

Name	Type
astro	Patch
@e2e/astro-component	Patch
@e2e/lit-component	Patch
@e2e/preact-component	Patch
@e2e/react-component	Patch
@e2e/solid-component	Patch
@e2e/svelte-component	Patch
@e2e/e2e-tailwindcss	Patch
@e2e/ts-resolution	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Princesseuh]

In my opinion, docs should be updated to reflect this change, the current sentence is confusing if we're actually using clsx

This is inspired by lukeed’s popular clsx helper library, but built directly into Astro itself.

[FredKSchott]

In my opinion, docs should be updated to reflect this change, the current sentence is confusing if we're actually using clsx

Agreed!

Grr, I just realized that clsx doesn't support Sets, while we do. I actually agree that Sets should be supported, so now I'm not sure what I want anymore :) Given that this isn't a simple drop-in I might just suggest abandoning this PR.