Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape template literals in prebuild script #3745

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Escape template literals in prebuild script #3745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e08ddf
chore: escape template literals in prebuild script
natemoo-re Jun 28, 2022
9b80d2a
Merge branch 'main' into fix/escape-prebuilt
natemoo-re Jun 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions scripts/cmd/prebuild.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
import * as terser from 'terser';
import esbuild from 'esbuild';
import glob from 'tiny-glob';
import fs from 'fs';
import path from 'path';
import { pathToFileURL, fileURLToPath } from 'url';

function escapeTemplateLiterals(str) {
return str.replace(/\`/g, '\\`').replace(/\$\{/g, '\\${');
}

export default async function prebuild(...args) {
let buildToString = args.indexOf('--to-string');
if (buildToString !== -1) {
Expand Down Expand Up @@ -49,7 +52,7 @@ export default async function prebuild(...args) {
* to generate this file.
*/

export default \`${esbuildresult.code.trim()}\`;`;
export default \`${escapeTemplateLiterals(esbuildresult.code.trim())}\`;`;
const url = getPrebuildURL(filepath);
await fs.promises.writeFile(url, mod, 'utf-8');
}
Expand Down