Update out directories for Netlify Functions #3381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a4af181 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
approved these changes
May 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes the outDir to /dist/ for regular Netlify Functions (not Edge Functions) - as /netlify/ is a directory that Netlify users add their own Edge Functions to, and we don't want to overwrite them when building.
Modifies the out directory for the entry.js file to ./.netlify/functions-internal (used for integration functions) as we do not want this file in the dist directory.
Testing
This change was tested against an astro project, set up with the @astro/netlify package, with the
import netlify from '@astrojs/netlify/functions';configuration.. I have confirmed that it builds the site to the dist directory, and puts the relevant server file in ./.netlify/functions-internalDocs
Updated documentation in package README.md