-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: create astro
add install step
#3190
Conversation
🦋 Changeset detectedLatest commit: b25b45b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job! Left some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a +1 to @JuanM04's comment.
Also let's plan on a final review of the output, wording, etc. I have a few small nits/thoughts but would rather save for the end
Changes
create astro
- Would you like us to run "MY_PACKAGE_MANAGER install?"pnpm dev
,yarn dev
, ornpm run dev
.yarn create astro
vspnpm create astro
, etc.Testing
Add super fancy unit tests to walk through the CLI:
install-step.test.js
🔥Watch it go 🏃♂️
create-astro-install-demo.mov
Docs
N/A