Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: change to shiki default md renderer #2824

Merged
merged 13 commits into from
Mar 18, 2022

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Mar 17, 2022

Changes

  • Change markdown-remark default to 'shiki'
  • Update all examples with Prism-specific styles to Shiki-specific styles
    • examples/with-markdown
    • examples/docs
    • examples/blog

Testing

WIP

Docs

Whole-new explainer on defaults, config, and creating a custom theme ❤️
The PR

@changeset-bot
Copy link

changeset-bot bot commented Mar 17, 2022

🦋 Changeset detected

Latest commit: 4e49a35

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/markdown-remark Minor
astro Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) feat: markdown Related to Markdown (scope) labels Mar 17, 2022
@bholmesdev bholmesdev marked this pull request as draft March 17, 2022 16:48
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once tests are passing!

.changeset/big-oranges-behave.md Outdated Show resolved Hide resolved
@bholmesdev bholmesdev force-pushed the feat/change-to-shiki-default-md-renderer branch from a279666 to a22b2f4 Compare March 17, 2022 21:20
@bholmesdev bholmesdev marked this pull request as ready for review March 17, 2022 21:20
@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Mar 17, 2022
@bholmesdev bholmesdev merged commit 0a3d3e5 into main Mar 18, 2022
@bholmesdev bholmesdev deleted the feat/change-to-shiki-default-md-renderer branch March 18, 2022 21:29
@github-actions github-actions bot mentioned this pull request Mar 18, 2022
@github-actions github-actions bot mentioned this pull request Mar 25, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* feat: change Shiki to default

* refactor: update blog styles for shiki

* feat: update examples/docs styles for Shiki

* refactor: remove Prism-ish examples/docs styles

* refactor: simplify rules with `all: unset`

* refactor: remove Prism styles

* refactor: examples/with-md remove Prism-specific line-highlight

* chore: add changeset

* chore: update changeset versions

* refactor: update syntax highlight test for scoped styles

* fix: apply scoped style class to pre and span lines

* feat: test that scoped styles cascade to shiki code

* refactor: pass scopedClassName explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants