Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on environment variables #1575

Closed

Conversation

AsyncBanana
Copy link
Contributor

Changes

Testing

None because no core code was changed

Docs

See changes

@AsyncBanana AsyncBanana requested a review from a team as a code owner October 17, 2021 13:58
@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2021

⚠️ No Changeset found

Latest commit: 5337cad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Oct 17, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 5337cad

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/616c2c0be306fa0008b139c3

😎 Browse the preview: https://deploy-preview-1575--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Oct 17, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 5337cad

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/616c2c0b32e17c00085a036d

😎 Browse the preview: https://deploy-preview-1575--astro-docs-2.netlify.app

@matthewp
Copy link
Contributor

Thanks, this is super valuable! However, given that we are hoping to get 0.21 out around the end of the month and that version will use Vite instead of Snowpack, I'm not sure its a good idea to merge in Snowpack-heavy documentation. Would you be open to submitting this against the next branch and rework it to show how to use this will Vite?

@AsyncBanana
Copy link
Contributor Author

Ok, I have created a new version for Vite in #1587.

@AsyncBanana AsyncBanana deleted the environment-variable-docs branch October 18, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📘 DOC: Missing docs on environment variable usages
2 participants