-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lit version to v2 #1445
Update lit version to v2 #1445
Conversation
🦋 Changeset detectedLatest commit: e758769 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). astro-docs – ./docs🔍 Inspect: https://vercel.com/pikapkg/astro-docs/BDKuN1KSzVWMkKRP13xasYPicaoD [Deployment for e758769 canceled] astro-www – ./www🔍 Inspect: https://vercel.com/pikapkg/astro-www/7QAMXLKr9A5ypnRB57mDihETm6jy [Deployment for e758769 canceled] |
Thanks! It looks like it's having trouble accessing The Lit renderer installs Lit's window shim on the global so it should be there: https://github.com/snowpackjs/astro/blob/main/packages/renderers/renderer-lit/server-shim.js#L1 Might need to debug why we are getting this error. |
@matthewp It seems strange that it passed on Node v12 to me but not Node v14. I will keep trying to dig into it |
@matthewp Seems all the errors stem from an update to |
@matthewp Sorry for all the pings. I found the root cause but I'm not sure what solution we want to go with. Root issue: So by adding I'm also quite confused why all React, Vue, Preact, and Markdown are all reliant upon this shim being installed in a test. Seems to me that this is just bad setup for those tests. If they were to run before that shim were to be installed, they would all fail as they are currently. |
Thanks for the research @stramel! I don't think that those other tests need the shim, but rather that the existence of the shim causes their code to branch (due to some feature detection I imagine). So this is kind of a good thing, because it's catching "what happens when you have Lit & React/etc. in the same project). I'm fine with adding the |
Changes
Bumps to the official v2 release of Lit and the official v1 release of @lit-labs/ssr in the lit renderer
Testing
Tests are passing
Docs
Shouldn't need any documentation update.