-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(routing): external redirects #12979
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7038546 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
69681fb
to
a0e7716
Compare
a0e7716
to
e0d2234
Compare
CodSpeed Performance ReportMerging #12979 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is blocked because it contains a minor
changeset. A reviewer will merge this at the next release if approved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This requires no changes at the adapter level right?
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
It shouldn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @ematipico ! Just a suggestion of what you could do in case you wanted to add a little hype to the changeset. Choose whatever kind of wording you want, but I think 2 sentences works nice here: one to link to redirects
for reference, and one to explicitly say "provide a URL" to introduce the code sample.
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@ematipico the build is failing, I think that's because of this deletion |
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Changes
Closes PLT-2745
This PR adds support for external directs in the
redirects
configuration:http://
orhttps://
or the URL isn't parsable[...slug]
,[slug]
underscore-redirects
(apart from tiny refactors)Testing
Added new tests
Docs
withastro/docs#10704
/cc @withastro/maintainers-docs for feedback!