Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "blocking" and "disabled" attributes to the TypeScript definition of the HTML link element #12955

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

martrapp
Copy link
Member

@martrapp martrapp commented Jan 9, 2025

Changes

I missed the "blocking" attribute of the <link> element.
Added it. Came across missing "disabled" attribute. Added that, too.
Started sorting, but did not complete, because I haven't found "charset" at MDN.

Testing

n/a

Docs

n/a

Improvements of the changeset are welcome as always.

Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 47e3673

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 9, 2025
@martrapp martrapp requested a review from Princesseuh January 9, 2025 21:55
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good catch

@martrapp martrapp merged commit db447f2 into main Jan 10, 2025
14 checks passed
@martrapp martrapp deleted the mt/blocking branch January 10, 2025 05:04
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants