Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: better types #12944

Merged
merged 2 commits into from
Jan 9, 2025
Merged

chore: better types #12944

merged 2 commits into from
Jan 9, 2025

Conversation

ematipico
Copy link
Member

Changes

This is a follow-up of #12937 (comment)

Testing

CI should pass

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b58eb37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 9, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 9, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12944 will not alter performance

Comparing chore/better-request-types (b58eb37) with main (673a518)

Summary

✅ 6 untouched benchmarks

@ematipico ematipico requested a review from ascorbic January 9, 2025 14:46
@ematipico ematipico merged commit 35d77b4 into main Jan 9, 2025
16 checks passed
@ematipico ematipico deleted the chore/better-request-types branch January 9, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

@ascorbic ascorbic ascorbic approved these changes

@florian-lefebvre florian-lefebvre Awaiting requested review from florian-lefebvre

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ematipico @ascorbic @bluwy