Run astro:config:done hook before generating route manifest
#12936
Conversation
🦋 Changeset detectedLatest commit: eca2174 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| settings.buildOutput = getPrerenderDefault(config) ? 'static' : 'server'; | ||
| // NOTE: `buildOutput` may already be set by `runHookConfigDone` if the adapter only | ||
| // support server build output | ||
| settings.buildOutput ??= getPrerenderDefault(config) ? 'static' : 'server'; |
There was a problem hiding this comment.
So the reordering of hooks is for this to work right? Just to make sure I understand, we don't want to infer the build output if the adapter locks it. Is that right?
There was a problem hiding this comment.
Yup. This code will only work as a fallback
|
This requires changes to the integration reference:
|
|
Yeah I suppose we have to update it if this PR works. Would technically be kinda breaking, though otherwise I don't see an easy way else to fix this. |
|
Yes technically breaking, I have some integrations relying on the order. That being said, I think the hook is recent enough so it's not used a lot yet, let's do it if it's the only way. Most important thing is to check it doesn't break official adapters |
CodSpeed Performance ReportMerging #12936 will not alter performanceComparing Summary
|
|
I think an alternative to this is to directly set the output to EDIT: No this isn't quite enough |
|
Closing as I've got a different fix. |
|
Is this the recommended fix now: #12982? |
|
Yeah, I was testing it a bit more and I think that's the proper solution for now. |
Changes
fix #12803
Testing
n/a. it's a bit hard to add test for this one
Docs
n/a. bug fix.