fix(rss): use "application/rss+xml" as default content type and allow… #12643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2d9820c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
32753ea to
82947f8
Compare
… set custom charset According to https://www.rssboard.org/rss-mime-type-application.txt The MIME type for RSS feed should be "application/rss+xml" It also need to set the charset in content type for non-english content
82947f8 to
2d9820c
Compare
|
Thanks. Changing the mimetype makes sense, but I'm unsure about the charset change. The encoding is already set to UTF-8 in the XML declaration. Is there a reason that the user might want to change that? If there is, we'd need to ensure that the generated feed also used that encoding and had the correct encoding in the declaration. |
|
Looks the entire project are using utf-8. so I'll send another PR for this changes without charset option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… set custom charset
According to https://www.rssboard.org/rss-mime-type-application.txt The MIME type for RSS feed should be "application/rss+xml" It also need to set the charset in content type for non-english content
Changes
utf-8is defaultTesting
Docs