Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attribute rendering for boolean values (take 2) #11660

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Fix attribute rendering for boolean values (take 2) #11660

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52bdda4
Fix attribute rendering for boolean values (#11369)
bluwy Jul 1, 2024
4891b7f
Better changeset
bluwy Aug 9, 2024
b457110
More space
bluwy Aug 9, 2024
0b7f19a
Apply suggestions from code review
bluwy Aug 9, 2024
1b6ff82
Apply suggestions from code review
bluwy Aug 12, 2024
351305c
Typo
bluwy Aug 12, 2024
81ab69a
Apply suggestions from code review
bluwy Aug 13, 2024
411ceab
Update .changeset/small-ties-sort.md
bluwy Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update .changeset/small-ties-sort.md 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
  • Loading branch information
@bluwy @sarah11918
bluwy and sarah11918 authored Aug 13, 2024
commit 411ceaba938daa1c0e5ed3e82949b1ef160cd99f
2 changes: 1 addition & 1 deletion .changeset/small-ties-sort.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Fixes attribute rendering for non-[boolean HTML attributes](https://developer.mo

Previously, non-boolean attributes may not have included their values when rendered to HTML. In Astro v5.0, the values are now explicitly rendered as `="true"` or `="false"`

In the following `.astro` examples passed values of `true` and `false`, only `allowfullscreen` is a boolean attribute:
In the following `.astro` examples, only `allowfullscreen` is a boolean attribute:

```astro
<!-- src/pages/index.astro -->
Expand Down
Loading