Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: extract fs helpers into shared internal-helpers package #11323

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ascorbic
Copy link
Contributor

Changes

The @astrojs/vercel package includes some filesystem helpers that would be useful in other packages. This PR moves them into the internal-helpers package.

Testing

There should be no change in behaviour

Docs

Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: 906ebe9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jun 24, 2024
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the vercel integration have the @astrojs/internal-helpers as dependency?

@ascorbic
Copy link
Contributor Author

Does the vercel integration have the @astrojs/internal-helpers as dependency?

Yup

@ascorbic ascorbic merged commit 41064ce into main Jun 24, 2024
13 checks passed
@ascorbic ascorbic deleted the share-fs-helpers branch June 24, 2024 09:12
@astrobot-houston astrobot-houston mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants