Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions: restore api context param #11112

Merged
merged 7 commits into from
May 22, 2024
Merged

Actions: restore api context param #11112

merged 7 commits into from
May 22, 2024

Conversation

bholmesdev
Copy link
Contributor

Changes

  • Go back to accessing API Context from the second handler() param
  • Add @deprecated note to the getApiContext() function

Testing

Update fixture to use second param

Docs

Updated RFC

@bholmesdev bholmesdev marked this pull request as ready for review May 21, 2024 15:07
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 21, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: b50d489

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 21, 2024
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label May 21, 2024
github-actions[bot]
github-actions bot previously requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

bholmesdev and others added 2 commits May 21, 2024 11:40
@bholmesdev @florian-lefebvre
edit: apiContext -> context
c7f426b 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@bholmesdev @florian-lefebvre
refactor: apiContext -> context
0c230a3 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
florian-lefebvre
florian-lefebvre approved these changes May 21, 2024
View reviewed changes
@bholmesdev @florian-lefebvre
refactor: apiContext -> context
b50d489 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@florian-lefebvre florian-lefebvre removed the semver: minor Change triggers a `minor` release label May 21, 2024
@florian-lefebvre
Copy link
Member

Btw you'll probably want to rename the stubs, replacing Locals by Context or something like that

@bholmesdev
Copy link
Contributor Author

@florian-lefebvre Ah, I think you're referencing a different PR with that comment. But yes!

@bholmesdev bholmesdev merged commit 29a8650 into main May 22, 2024
13 checks passed
@bholmesdev bholmesdev deleted the feat/restore-api-context-param branch May 22, 2024 12:06
@astrobot-houston astrobot-houston mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@ematipico ematipico ematipico approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bholmesdev @florian-lefebvre @matthewp @ematipico