fix: conflict between rewrite and actions middleware

[florian-lefebvre]

Changes

• When using rewrite with actions, a case where locals._actionsInternal is reassigned can occur. However, there's a protection to disable reassigning it so it fails. This PR does not attempt to reassign if it already exists

Testing

Manual patch in a private project

Docs

N/A, bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 960c8d4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[bholmesdev]

Question about a conditional check for the success case. Also curious what is triggering the reassignment? Is it an object spread?

[florian-lefebvre]

Well I think the case is kinda tricky but basically, I have this middleware

(context, next) => {
	context.locals.data = null
	context.locals.foo = async (data) => {
		context.locals.data = data
		return await next("/bar")
	}

	return next()
}

then I can call it in an astro route:

return await Astro.locals.bar("abc")

I need to call next to be able to keep the data in the rewritten page, I can't call rewrite