-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db: add login flow for web containers #10816
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a57ac30 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bholmesdev
changed the title
efeat: add login flow for web containers
db: add login flow for web containers
Apr 18, 2024
!preview db-web |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview db-web |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
matthewp
reviewed
Apr 19, 2024
matthewp
reviewed
Apr 19, 2024
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a check to
astro login
for your environment. When in Codespaces or Stackblitz, use a manual login flow that lets you enter your session ID rather than using redirects.Related Studio PR: https://github.com/withastro/studio/pull/589
studio-login.1.mov
Testing
Manual testing for the preview package on Stackblitz and Codespaces, connecting to a local Studio instance with a tunnel.
Docs