Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ASTRO_DATABASE_FILE work with file paths #10631

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Make ASTRO_DATABASE_FILE work with file paths #10631

merged 2 commits into from
Apr 1, 2024

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 1, 2024

Changes

  • Moves logic for the environment variable into a helper function. Normalizes a file path, relative file path, and file URL, back into a file URL.

Testing

  • Added new tests

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2024

🦋 Changeset detected

Latest commit: 802abb4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthewp matthewp merged commit 157392e into main Apr 1, 2024
13 checks passed
@matthewp matthewp deleted the db-file-env branch April 1, 2024 15:39
@astrobot-houston astrobot-houston mentioned this pull request Apr 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewp @bluwy