reset history title after push/replace but prior to assignment to location #10605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a673398 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
lgtm, but can you add a changeset? |
Looked so small and innocent. Done. |
ematipico
approved these changes
Mar 29, 2024
Hi @ematipico, yes, sure ;-) Single stepped through the code and was really surprised that Chrome pushes another state to the history when assigning a text fragment for the same page. The "moveToLocation()" code could certainly do with a reworking, but at least it's not wrong now. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We change the history title while we push / replace the history during view transition.
It got changes back at the end of the function which turned out to be too late when using text fragments (
#:~:text=...) as Chrome pushes another state.Testing
Edit:
n./a.Tested manually.Docs
bug fix n./a.