Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[db] remove token creation wait time #10477

Merged
merged 1 commit into from
Mar 19, 2024
Merged

[db] remove token creation wait time #10477

merged 1 commit into from
Mar 19, 2024

Conversation

FredKSchott
Copy link
Member

Changes

  • The /auth/cli/token-create endpoint is being updated to handle the propagation itself, meaning that the client-side wait is no longer needed.
  • This means that older versions of this code will run ~2sec longer than actually needed. We can also add a query-param to opt-in to the server-side handling to avoid this, but ultimately it didn't feel worth it to me. Happy to revisit if others disagree.
  • For older versions of this code, there will be no change to the user experience, just a shifting of responsibility out of the client.

Testing

  • N/A

Docs

  • N/A

Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: 9fb9360

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@FredKSchott FredKSchott merged commit 124cdd6 into main Mar 19, 2024
13 checks passed
@FredKSchott FredKSchott deleted the remove-token-wait branch March 19, 2024 03:45
@astrobot-houston astrobot-houston mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants