Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static imports for integration seed files in astro:db #10381

Merged
merged 10 commits into from
Mar 11, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Mar 11, 2024

Changes

  • Switches from dynamic to static imports for integration seed files in the astro:db virtual module.
  • Fixes a bug where builds would fail silently when using integrations.

Testing

Added a simple test with build output for the integrations fixture and also tested astro build manually locally.

Docs

N/A — bug fix

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 9b0785c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How integracious of you to make this fix 🙇

@bholmesdev bholmesdev merged commit 8cceab5 into main Mar 11, 2024
13 checks passed
@bholmesdev bholmesdev deleted the chris/fix-db-integration-builds branch March 11, 2024 13:51
@astrobot-houston astrobot-houston mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants