Remove react integration ssr.external config

withastro · Jan 16, 2025 · e8b121d · e8b121d
1 parent df90e6d
commit e8b121d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/.changeset/many-pianos-develop.md b/.changeset/many-pianos-develop.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/react': patch
+---
+
+Removes hardcoded `ssr.external: ['react-dom/server', 'react-dom/client']` config that causes issues with adapters that bundle all dependencies (e.g. Cloudflare). These externals should already be inferred by default by Vite when deploying to a server environment.
diff --git a/packages/integrations/react/src/index.ts b/packages/integrations/react/src/index.ts
@@ -59,7 +59,6 @@ function getViteConfiguration(
 		},
 		plugins: [react({ include, exclude, babel }), optionsPlugin(!!experimentalReactChildren)],
 		ssr: {
-			external: reactConfig.externals,
 			noExternal: [
 				// These are all needed to get mui to work.
 				'@mui/material',

diff --git a/packages/integrations/react/src/version.ts b/packages/integrations/react/src/version.ts
@@ -19,16 +19,13 @@ export const versionsConfig = {
 	17: {
 		server: '@astrojs/react/server-v17.js',
 		client: '@astrojs/react/client-v17.js',
-		externals: ['react-dom/server.js', 'react-dom/client.js'],
 	},
 	18: {
 		server: '@astrojs/react/server.js',
 		client: '@astrojs/react/client.js',
-		externals: ['react-dom/server', 'react-dom/client'],
 	},
 	19: {
 		server: '@astrojs/react/server.js',
 		client: '@astrojs/react/client.js',
-		externals: ['react-dom/server', 'react-dom/client'],
 	},
 };