Skip to content

Commit

Permalink
Add missing global attributes to JSX definition (#9404)
Browse files Browse the repository at this point in the history
* fix: add some missing attributes to our JSX definitions

* chore: changeset

* fix: use empty string as type
  • Loading branch information
Princesseuh authored Dec 11, 2023
1 parent f47b85c commit 8aa17a6
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/dull-masks-eat.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Fixed some newer HTML attributes not being included in our type definitions
10 changes: 8 additions & 2 deletions packages/astro/astro-jsx.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,8 @@ declare namespace astroHTML.JSX {
| 'search'
| 'send'
| undefined
| null;
| null;
exportparts?: string | undefined | null;
hidden?: boolean | string | undefined | null;
id?: string | undefined | null;
inert?: boolean | string | undefined | null;
Expand All @@ -533,18 +534,23 @@ declare namespace astroHTML.JSX {
| undefined
| null;
is?: string | undefined | null;

// Microdata API
itemid?: string | undefined | null;
itemprop?: string | undefined | null;
itemref?: string | undefined | null;
itemscope?: boolean | string | undefined | null;
itemtype?: string | undefined | null;

lang?: string | undefined | null;
part?: string | undefined | null;
popover?: boolean | string | undefined | null;
slot?: string | undefined | null;
spellcheck?: 'true' | 'false' | boolean | undefined | null;
style?: string | StyleObject | undefined | null;
tabindex?: number | string | undefined | null;
title?: string | undefined | null;
translate?: 'yes' | 'no' | undefined | null;
translate?: 'yes' | 'no' | '' | undefined | null;

// <command>, <menuitem>
radiogroup?: string | undefined | null;
Expand Down

0 comments on commit 8aa17a6

Please sign in to comment.