Remove internal vue handling in cloudflare integration #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2022507 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
commented
Jan 17, 2025
| vite.build ||= {}; | ||
| vite.build.rollupOptions ||= {}; | ||
| vite.build.rollupOptions.output ||= {}; | ||
| // @ts-expect-error | ||
| vite.build.rollupOptions.output.banner ||= | ||
| 'globalThis.process ??= {}; globalThis.process.env ??= {};'; | ||
|
|
||
| vite.build.rollupOptions.external = _config.vite.build?.rollupOptions?.external ?? []; |
There was a problem hiding this comment.
I removed this, and similarly for the vite.ssr.external handling that was in #210, as I don't think this line really affects anything. The default undefined setting is already an empty array.
ematipico
approved these changes
Jan 17, 2025
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Undo the stop gap done in #210, we no longer need this handling as it's fixed in the vue integration.
Testing
Existing tests should pass. There's a vue test.
Docs
n/a. bug fix.