fixes vue

withastro · Mar 29, 2024 · d72b318 · d72b318
1 parent 38da2ca
commit d72b318
Show file tree

Hide file tree

Showing 4 changed files with 1,299 additions and 1,942 deletions.
diff --git a/.changeset/shy-cooks-knock.md b/.changeset/shy-cooks-knock.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/cloudflare': patch
+---
+
+fixes an issue where projects using `@astrojs/vue` were unusable, due to marking dependencies as external
diff --git a/packages/cloudflare/package.json b/packages/cloudflare/package.json
@@ -34,7 +34,7 @@
     "miniflare": "^3.20240320.0",
     "esbuild": "^0.19.5",
     "tiny-glob": "^0.2.9",
-    "wrangler": "^3.36.0"
+    "wrangler": "^3.39.0"
   },
   "peerDependencies": {
     "astro": "^4.2.0"

diff --git a/packages/cloudflare/src/index.ts b/packages/cloudflare/src/index.ts
@@ -173,7 +173,14 @@ export default function createIntegration(args?: Options): AstroIntegration {
 					vite.ssr ||= {};
 					vite.ssr.target = 'webworker';
 					vite.ssr.noExternal = true;
-					vite.ssr.external = _config.vite.ssr?.external ?? [];
+
+					if (typeof _config.vite.ssr?.external === 'undefined') vite.ssr.external = [];
+					if (typeof _config.vite.ssr?.external === 'boolean')
+						vite.ssr.external = _config.vite.ssr?.external;
+					if (Array.isArray(_config.vite.ssr?.external))
+						vite.ssr.external = _config.vite.ssr?.external.filter(
+							(entry) => entry !== '@vue/server-renderer'
+						);
 
 					vite.build ||= {};
 					vite.build.rollupOptions ||= {};