Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-1501 - Add support for image variants #9

Merged
merged 15 commits into from
Nov 23, 2024
Merged

ENG-1501 - Add support for image variants #9

merged 15 commits into from
Nov 23, 2024

Conversation

daanpersoons
Copy link
Contributor

No description provided.

@daanpersoons daanpersoons requested a review from djbe August 23, 2024 23:09
@linear Linear
Copy link

linear bot commented Aug 23, 2024

ENG-1501 LS Innoventa: Nuxt monorepo deployment

djbe
djbe requested changes Aug 24, 2024
View reviewed changes
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
@daanpersoons daanpersoons force-pushed the monorepo-workflows branch 24 times, most recently from 0432c2b to bc98fd8 Compare August 25, 2024 19:13
@daanpersoons daanpersoons requested a review from djbe November 1, 2024 12:31
@djbe djbe force-pushed the monorepo-workflows branch from c18992b to 0843fc4 Compare November 22, 2024 03:11
@ernest-app ernest-app bot added 📃 S PR and removed 📃 XS PR labels Nov 22, 2024
@djbe djbe force-pushed the monorepo-workflows branch from 80c9c04 to 420e09f Compare November 22, 2024 03:32
@djbe djbe force-pushed the monorepo-workflows branch from 420e09f to cc0dd10 Compare November 22, 2024 03:42
@djbe djbe disabled auto-merge November 22, 2024 03:42
djbe
djbe approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@djbe djbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daanpersoons I've gone through it again:

  • Tweaked the input variants parameter to what I had, and applied the change to the LS Innoventa repo
  • Show variant name in job, makes it easier to see what deploys
  • Re-added the matrix for promotes, might as well 😅
  • Applied the changes to DO versions

Mind checking it over? I'm pretty sure I didn't break anything. If it's okay, I'll rebase this and merge it later today.

.github/workflows/workflow-promote-to-environment-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
.github/workflows/workflow-build-and-deploy-scaleway.yml Outdated Show resolved Hide resolved
@djbe
Copy link
Contributor

djbe commented Nov 23, 2024

Seems like the ls innocenta builds went fine today, so my changes are okay :D

@djbe djbe merged commit acb2a3a into main Nov 23, 2024
1 check passed
@djbe djbe deleted the monorepo-workflows branch November 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djbe djbe djbe approved these changes

Assignees
No one assigned
Labels
📃 S PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daanpersoons @djbe