Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kotlinx-coroutines-android from 1.4.2 to 1.4.3-native-mt #38

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 2, 2021

Bumps kotlinx-coroutines-android from 1.4.2 to 1.4.3-native-mt.

Release notes

Sourced from kotlinx-coroutines-android's releases.

1.4.3

General changes

  • Thread context is properly preserved and restored for coroutines without ThreadContextElement (#985)
  • ThreadContextElements are now restored in the opposite order from update (#2195)
  • Improved performance of combine with 4 parameters, thanks to @​alexvanyo (#2419)
  • Debug agent sanitizer leaves at least one frame with source location (#1437)
  • Update Reactor version in kotlinx-coroutines-reactor to 3.4.1, thanks to @​sokomishalov (#2432)
  • callsInPlace contract added to ReceiveChannel.consume (#941)
  • CoroutineStart.UNDISPATCHED promoted to stable API (#1393)
  • Kotlin updated to 1.4.30
  • kotlinx.coroutines are now released directly to MavenCentral
  • Reduced the size of DispatchedCoroutine by a field
  • Internal class TimeSource renamed to SchedulerTimeSource to prevent wildcard import issues (#2537)

Bug fixes

  • Fixed the problem that prevented implementation via delegation for Job interface (#2423)
  • Fixed incorrect ProGuard rules that allowed shrinking volatile felds (#1564)
  • Fixed await/asDeferred for MinimalStage implementations in jdk8 module (#2456)
  • Fixed bug when onUndeliveredElement wasn't called for unlimited channels (#2435)
  • Fixed a bug when ListenableFuture.isCancelled returned from asListenableFuture could have thrown an exception, thanks to @​vadimsemenov (#2421)
  • Coroutine in callbackFlow and produce is properly cancelled when the channel was closed separately (#2506)
Changelog

Sourced from kotlinx-coroutines-android's changelog.

Change log for kotlinx.coroutines

Version 1.4.3

General changes

  • Thread context is properly preserved and restored for coroutines without ThreadContextElement (#985)
  • ThreadContextElements are now restored in the opposite order from update (#2195)
  • Improved performance of combine with 4 parameters, thanks to @​alexvanyo (#2419)
  • Debug agent sanitizer leaves at least one frame with source location (#1437)
  • Update Reactor version in kotlinx-coroutines-reactor to 3.4.1, thanks to @​sokomishalov (#2432)
  • callInPlace contract added to ReceiveChannel.consume (#941)
  • CoroutineStart.UNDISPATCHED promoted to stable API (#1393)
  • Kotlin updated to 1.4.30
  • kotlinx.coroutines are now released directly to MavenCentral
  • Reduced the size of DispatchedCoroutine by a field
  • Internal class TimeSource renamed to SchedulerTimeSource to prevent wildcard import issues (#2537)

Bug fixes

  • Fixed the problem that prevented implementation via delegation for Job interface (#2423)
  • Fixed incorrect ProGuard rules that allowed shrinking volatile felds (#1564)
  • Fixed await/asDeferredforMinimalState` implementations in jdk8 module (#2456)
  • Fixed bug when onUndeliveredElement wasn't called for unlimited channels (#2435)
  • Fixed a bug when ListenableFuture.isCancelled returned from asListenableFuture could have thrown an exception, thanks to @​vadimsemenov (#2421)
  • Coroutine in callbackFlow and produce is properly cancelled when the channel was closed separately (#2506)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Apr 2, 2021
@ChristianoBolla-Appwise
Copy link
Contributor

I think this one is a bit strange... should we allow such native-mt version?

If I look at the Github for Coroutines it's just the 1.4.3 version 🤔
https://github.com/Kotlin/kotlinx.coroutines/releases

@ChristianoBolla-Appwise ChristianoBolla-Appwise requested a review from a team April 2, 2021 20:45
@ChristianoBolla-Appwise
Copy link
Contributor

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-android-1.4.3-native-mt branch from 2d7e06b to 65586a8 Compare April 12, 2021 11:26
@Glennmen
Copy link
Contributor

@ChristianoBolla-Appwise I also don't understand why it used the native-mt version. For now I would suggest to not merge this, I will try to do some research.

@dependabot dependabot bot force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-android-1.4.3-native-mt branch from 65586a8 to 4f89d51 Compare April 15, 2021 09:17
@dependabot dependabot bot force-pushed the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-android-1.4.3-native-mt branch from 4f89d51 to da90f82 Compare April 15, 2021 09:18
@Glennmen Glennmen self-assigned this Apr 15, 2021
@ChristianoBolla-Appwise
Copy link
Contributor

ChristianoBolla-Appwise commented Apr 15, 2021

I wasn't even aware of what the native-mt part entailed, so with a bit of searching I found this article.

Mainly talks about that there was an issue with multi threading in Ktor and such...

@Glennmen
Copy link
Contributor

True I found the same, as I think that we don't need to have native Kotlin multithreading (yet?) I will try to figure out if I can add an ignore filter for -native-mt versions.

@Glennmen
Copy link
Contributor

After some research and testing it seems that Dependabot doesn't support regex filtering for versions. I will try to keep track of this issue in the dependabot-core project.
For now I suggest to close this PR and only merge none -native-mt versions.

Removed '-native-mt' as we do not need the multithreading coroutines for now.
@ChristianoBolla-Appwise ChristianoBolla-Appwise merged commit 97d389a into master Apr 16, 2021
@ChristianoBolla-Appwise ChristianoBolla-Appwise deleted the dependabot/gradle/org.jetbrains.kotlinx-kotlinx-coroutines-android-1.4.3-native-mt branch April 16, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants