Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor build_examples.py #108

Closed
wants to merge 2 commits into from
Closed

Refactor build_examples.py #108

wants to merge 2 commits into from

Conversation

17o2
Copy link
Collaborator

@17o2 17o2 commented Jul 20, 2020

  • Use pathlib.Path instead of os.path
  • Fix order of files while building
  • Consolidate code for building demos, examples and tutorial
  • Change argument from tutorials to tutorial to remain consistent
  • Add some indentation in console output for better readability

@17o2
Refactor build_examples.py
26f38c9 
- Use `pathlib.Path` instead of `os.path`
- Fix order of files while building
- Consolidate code for building demos, examples and tutorial
- Change argument from `tutorials` to `tutorial` to remain consistent
- Add some indentation in console output for better readability
@17o2 17o2 force-pushed the bugfix/build-examples branch from a4e0c72 to 26f38c9 Compare July 20, 2020 10:58
@17o2 17o2 closed this Jul 20, 2020
@17o2 17o2 deleted the bugfix/build-examples branch July 20, 2020 11:27
@17o2 17o2 restored the bugfix/build-examples branch July 20, 2020 11:28
@17o2
Copy link
Collaborator Author

17o2 commented Jul 20, 2020

Not sure what happened here. New PR #110 is open.

@wireviz wireviz locked as resolved and limited conversation to collaborators Jul 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@17o2