Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting and add missing link in quickstart.md #20

Merged

Conversation

AntoniKania
Copy link
Contributor

@AntoniKania AntoniKania commented Aug 5, 2023

References

While reading the documentation on GitHub, I came across some pretty weird formatting. It looks like one backtick sign was missing. After looking at .md file, I also found a single ] sign after the word examples, I think that link to https://github.com/wiremock/wiremock-testcontainers-go/blob/main/examples/quickstart/quickstart_test.go should be placed there, so I also added that. If that wasn't intended, please let me know, and I will remove that :)

Screenshots before and after the change:

  • before
    image
  • after
    image

Submitter checklist

  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@AntoniKania AntoniKania force-pushed the fix-formatting-in-quickstart-md branch from 4a778db to 6c6be82 Compare August 5, 2023 14:21
@AntoniKania AntoniKania changed the title Fix formatting: Add missing backtick in quickstart.md Fix formatting and add missing link in quickstart.md Aug 5, 2023
@AntoniKania AntoniKania force-pushed the fix-formatting-in-quickstart-md branch from 6c6be82 to b5e5475 Compare August 5, 2023 15:15
Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oleg-nenashev oleg-nenashev added the documentation Improvements or additions to documentation label Aug 6, 2023
@oleg-nenashev oleg-nenashev merged commit 42be697 into wiremock:main Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants