Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not send mls message to self mls conversations when mls is not enabled on the team (WPB-16202) #18793

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

thisisamir98
Copy link
Contributor

@thisisamir98 thisisamir98 commented Feb 24, 2025

BugWPB-16202 [Web] MLS Error with self conversation when MLS is not enabled for the team

Description

const selfConversations = this.conversationState.getSelfConversations(supportsMLS());

problem was this line.
when trying to send a message to self we get all the self conversations
if mls is enabled we also include self mls conversations
the condition for checking if mls is enabled was to only check if we support cryptography apis, no check to see if MLS is also enabled in the team as well or not!

changing the above line to this fixes it:

const selfConversations = this.conversationState.getSelfConversations(
  supportsMLS() && this.teamState.isMLSEnabled(),
);

@thisisamir98 thisisamir98 merged commit 432fe07 into dev Feb 24, 2025
14 of 15 checks passed
@thisisamir98 thisisamir98 deleted the WPB-16202 branch February 24, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants